Aaron Schulz [Wed, 10 May 2017 02:32:24 +0000 (19:32 -0700)]
Make LocalPasswordPrimaryAuthenticationProviderTest use TS_MW timestamp conversion
Bug: T75174
Change-Id: I217a8e1847a21d54434693fafa7f618ec5840876
Aaron Schulz [Wed, 10 May 2017 02:25:56 +0000 (19:25 -0700)]
Avoid assuming a user with ID 0 exists in ApiMainTest::testAssert
If the load() triggered by User method calls fails, then mId becomes 0
which means there is no "user" right set in getAutomaticGroups().
Bug: T75174
Change-Id: I2d719e4b96c0142e9d408aa2d4f7c5e7a767a754
Aaron Schulz [Wed, 10 May 2017 01:27:28 +0000 (18:27 -0700)]
Fix some postgres test failures
Bug: T75174
Change-Id: If9812ae301f0af84fa012e2e980b92036c1b29b2
Aaron Schulz [Wed, 10 May 2017 01:41:22 +0000 (18:41 -0700)]
Make loadWatchedItem() coerce the DB timestamp to TS_MW
Bug: T75174
Change-Id: Ie72bd17b424ba857d0b4a22227c9cffad0853050
Volker E [Wed, 10 May 2017 01:21:26 +0000 (18:21 -0700)]
Update OOjs UI to v0.21.3
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.21.3
Change-Id: I53696e023197ae4dd85605d6615e9faceda05398
jenkins-bot [Wed, 10 May 2017 00:32:21 +0000 (00:32 +0000)]
Merge "Add missing addQuotes() to ChangesListSpecialPage"
jenkins-bot [Wed, 10 May 2017 00:29:42 +0000 (00:29 +0000)]
Merge "Make registerTempTableOperation() detect TRUNCATE operations"
Aaron Schulz [Tue, 9 May 2017 23:13:31 +0000 (16:13 -0700)]
Add missing addQuotes() to ChangesListSpecialPage
Bug: T75174
Change-Id: I34a2a3e8661edff68b115e349baddcec0bd14629
Gilles Dubuc [Wed, 26 Apr 2017 12:01:49 +0000 (14:01 +0200)]
Store original media dimensions as additional header
For storage repos that support headers (such as Swift), this will store the original
media dimensions as an extra custom header, X-Content-Dimensions.
The header is formatted to minimize its length when dealing with multipage
documents, by expressing the information as page ranges keyed by dimensions.
Example for a multipage documents with some pages of different sizes:
X-Content-Dimensions: 1903x899:1-9,11/1903x873:10
Example for a single page document:
X-Content-Dimensions: 800x600:1
Bug: T150741
Change-Id: Ic4c6a86557b3705cf75d074753e9ce2ee070a6df
Aaron Schulz [Sun, 30 Apr 2017 18:59:23 +0000 (11:59 -0700)]
Make registerTempTableOperation() detect TRUNCATE operations
Bug: T145947
Change-Id: I6094624fc594b23b1df6107f7ac1c3d93f609ebc
Translation updater bot [Tue, 9 May 2017 19:56:20 +0000 (21:56 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I13d63f8e59ea5eea6b3a3760075d754064c5fea0
jenkins-bot [Tue, 9 May 2017 18:38:57 +0000 (18:38 +0000)]
Merge "Allow callback functions for creating jobs"
Lucas Werkmeister [Thu, 4 May 2017 16:00:28 +0000 (18:00 +0200)]
Allow callback functions for creating jobs
$wgJobClasses can now specify a factory function for creating a job,
instead of a class to be instantiated directly. This makes it possible
to inject services in a job constructor, and register a factory function
that calls the constructor with default services.
This follows Ieb85493a7765 and Ia2107dc5af78, which introduced factory
functions for API modules and special pages.
Change-Id: I0461e59da2a8fa6681e3b1fcdfc38bfed7f3ac32
jenkins-bot [Tue, 9 May 2017 16:51:40 +0000 (16:51 +0000)]
Merge "Revised styling of sister-search sidebar."
jenkins-bot [Tue, 9 May 2017 11:41:48 +0000 (11:41 +0000)]
Merge "Change delimiter for multiple namespaces and tags"
Matthew Flaschen [Mon, 8 May 2017 05:06:12 +0000 (01:06 -0400)]
Change delimiter for multiple namespaces and tags
It's ; for namespaces (since that is generally what we're using,
e.g. for STRING_OPTIONS), and | for tags. I would have
preferred them to all be consistent, but there is one revision
that has a ;, and this seems better than modifying the DB.
Comma is already used as a delimiter between separate parameters
(e.g. hideanons and namepsace).
Also, fix multiple namespaces for parseParameters and add test
cases.
Bug: T164132
Bug: T164133
Change-Id: Iad061e0bc17e3522a3f5d330ac2c8bf9cf0e614f
jenkins-bot [Tue, 9 May 2017 02:32:38 +0000 (02:32 +0000)]
Merge "MessageCache: Avoid 'contributions' replicas"
jenkins-bot [Tue, 9 May 2017 02:32:34 +0000 (02:32 +0000)]
Merge "Prettify MessageCache::loadFromDB()-small query"
jenkins-bot [Tue, 9 May 2017 02:16:15 +0000 (02:16 +0000)]
Merge "ApiQueryRevisions: Restore use of rvstartid/rvendid as a tiebreaker"
Roan Kattouw [Tue, 9 May 2017 00:34:01 +0000 (17:34 -0700)]
Follow-up I5cede8: fix JS error when user has no filters saved
Change-Id: Ie7de070925874d2c29e185a90d65a0b0a72f07cd
Moriel Schottlender [Tue, 9 May 2017 00:14:07 +0000 (17:14 -0700)]
Followup I5cede8: Make the SavedQueries popup larger
The labels and popup are now slightly wider.
Bug: T151994
Bug: T164128
Change-Id: I64bd496ade241c800fcb0bb12023486e7d601a23
Moriel Schottlender [Mon, 8 May 2017 23:57:41 +0000 (16:57 -0700)]
Followup I5cede8: Fixup SavedQueries styling and event
Includes small styling fixes to saved queries and the ability
to update the label of an existing matched query if we rename
it.
Bug: T151994
Bug: T164128
Change-Id: Ic46b082cbfc3462f1d61895bcfc7c545902b2d1a
jenkins-bot [Mon, 8 May 2017 23:47:54 +0000 (23:47 +0000)]
Merge "RCFilters UI: Add a 'saved queries' quick filters feature"
Moriel Schottlender [Tue, 25 Apr 2017 23:59:50 +0000 (16:59 -0700)]
RCFilters UI: Add a 'saved queries' quick filters feature
Bug: T151994
Bug: T164128
Change-Id: I5cede87633147736d3b4ee5b8ea178ae21bd441f
Jan Drewniak [Fri, 7 Apr 2017 08:35:20 +0000 (10:35 +0200)]
Revised styling of sister-search sidebar.
Various improvements to the sister-search sidebar:
- using WM project favicons
- scoping CSS specific to sister-search sidebar
- making sister-search items more compact
Bug: T160724, T158938
Change-Id: I2794121ab83cbd4e2b8868150e4d61db376fa63b
Translation updater bot [Mon, 8 May 2017 20:03:26 +0000 (22:03 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I001225f92a48f46a6a9418958bd8603c2d3f403d
Brad Jorsch [Mon, 8 May 2017 18:18:03 +0000 (14:18 -0400)]
ApiQueryRevisions: Restore use of rvstartid/rvendid as a tiebreaker
If rvstartid/rvendid are used with revisions that have the same
timestamp, we should omit any revisions with the same timestamp but
out-of-range IDs.
Bug: T163532
Change-Id: I6ba5e0724945668dad55eec0d09cb7d3fe08e347
Brad Jorsch [Mon, 8 May 2017 18:00:26 +0000 (14:00 -0400)]
MessageCache: Avoid 'contributions' replicas
On WMF wikis, the partitioning of the revision table on the
'contributions' replicas makes the query here perform really poorly.
Specify 'api' as a hack for now to avoid those replicas.
This query happens once per day per wiki, plus when someone edits the
MediaWiki namespace, so it shouldn't be much additional load.
Bug: T164666
Change-Id: I5ae74d1702144f6475e9cfb13effc43389d66233
Brad Jorsch [Mon, 8 May 2017 17:57:13 +0000 (13:57 -0400)]
Prettify MessageCache::loadFromDB()-small query
Adjust the call so it uses JOIN...ON syntax rather than comma joins.
Bug: T164666
Change-Id: I93c8569620d543e9507d0adf1283443915f50d4b
jenkins-bot [Mon, 8 May 2017 17:12:53 +0000 (17:12 +0000)]
Merge "RC Filters: Single boolean filters are not contradictory"
Matthias Mullie [Tue, 14 Feb 2017 11:39:02 +0000 (12:39 +0100)]
Enable extensions to allow software-specific tags to be added by users
Bug: T121880
Bug: T121872
Change-Id: I6e054cfc065c8d8ae7d20a518b1963cd0551c5c2
jenkins-bot [Mon, 8 May 2017 15:13:44 +0000 (15:13 +0000)]
Merge "Fix a couple of issues with cleanupInvalidDbKeys.php maint script"
jenkins-bot [Mon, 8 May 2017 15:12:04 +0000 (15:12 +0000)]
Merge "RC Filters: Rephrase learner level message"
jenkins-bot [Mon, 8 May 2017 13:37:49 +0000 (13:37 +0000)]
Merge "Remove "(WMDE)" from my name in .mailmap"
jenkins-bot [Mon, 8 May 2017 13:35:36 +0000 (13:35 +0000)]
Merge "SpecialRecentchanges: Add class="mw-recentchanges-toplinks" to the "top links""
Stephane Bisson [Mon, 8 May 2017 13:32:46 +0000 (09:32 -0400)]
RC Filters: Rephrase learner level message
Bug: T164611
Change-Id: I5cd7b392fc89402e358084c8153bf8c2b9f1abd2
Stephane Bisson [Mon, 8 May 2017 12:58:05 +0000 (08:58 -0400)]
RC Filters: Single boolean filters are not contradictory
When all boolean filters of a group are selected
(for example: hideanons && hideliu), we consider the selection
unproductive and set them all to false.
Some legacy filters are alone in their group
(for example: ORES hideDamaging). They should not
be considered.
Bug: T164625
Change-Id: Ibb6721ccdfb226b3baac7775c30af230c68309e7
Thiemo Mättig [Mon, 8 May 2017 09:20:36 +0000 (11:20 +0200)]
Remove "(WMDE)" from my name in .mailmap
No other WMDE employee does have this. I think this is supposed to be
the "canonical name", which means it should not contain such extra
information, right?
Change-Id: Ic5bbb53d650843dfb627baa4c7508d88eba03729
Brad Jorsch [Fri, 21 Apr 2017 15:00:14 +0000 (11:00 -0400)]
API: Convert rvstartid/rvendid to timestamps for query
We tried something like this once before, but reverted it because it was
an unintended behavior change (see T98467). This time it's intended, we
need it for query optimization.
The behavior changes here are:
* rvstartid/rvendid is exactly equivalent to specifying rvstart/rvend
with the corresponding revisions' timestamps.
* If the revision for rvstartid/rvendid is not found in the database, an
error will be thrown.
This will pull timestamps from deleted revisions, i.e. the `archive`
table. While this is technically an information leak (that some revision
ID exists as a deleted revision and the time the revision was made),
it's minor and in line with the information revealed in Tool Labs thanks
to T51088.
Bug: T163532
Change-Id: Ida64a377c38b3553aa82ac754d80e8f898caf6c5
jenkins-bot [Mon, 8 May 2017 05:43:39 +0000 (05:43 +0000)]
Merge "Have Title::get(Next|Previous)RevisionID sort by timestamp"
Brad Jorsch [Fri, 21 Apr 2017 18:14:11 +0000 (14:14 -0400)]
Have Title::get(Next|Previous)RevisionID sort by timestamp
Revision IDs are usually increasing as timestamp increases, but not
always. Callers almost certainly want next/previous timestamp when the
two differ.
This also takes care of a minor bug in the nearby getFirstRevision()
where it'll choose an arbitrary tied revision ID if there were multiple
revisions made in the same second.
Bug: T4930
Bug: T163532
Bug: T159319
Change-Id: Iab2060a0ad5e45edbaa0ff36e863cb014b8e876f
Brad Jorsch [Thu, 27 Apr 2017 16:58:17 +0000 (12:58 -0400)]
Wrap parser output in <div class="mw-parser-output">
This will allow CSS to target just the parser output, without also
accidentally targeting the edit form, diff tables, and so on.
Bug: T37247
Change-Id: If4eb5bf71f94fa366ec4eddb6964e8f4df6b824a
Depends-On: I330c6aa4aaee045614b1801ed34bc9e03be69650
Depends-On: I52a518fa44e017841fe78474012cd69823e0a41d
jenkins-bot [Sun, 7 May 2017 20:03:56 +0000 (20:03 +0000)]
Merge "Add DatabaseUpdater::modifyTable"
jenkins-bot [Sun, 7 May 2017 20:03:32 +0000 (20:03 +0000)]
Merge "CREDITS: remove duplicate entry for Nik Everett"
Translation updater bot [Sun, 7 May 2017 19:55:28 +0000 (21:55 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I2b3b0cb604caa001245786be38730195e242e621
jenkins-bot [Sun, 7 May 2017 19:42:27 +0000 (19:42 +0000)]
Merge "Add single angle quotation marks and to special characters"
Bryan Davis [Sun, 7 May 2017 17:13:39 +0000 (11:13 -0600)]
CREDITS: remove duplicate entry for Nik Everett
Change-Id: I8bc4bcecd12aa4dc41e1826896dbe89104958125
jenkins-bot [Sun, 7 May 2017 17:09:46 +0000 (17:09 +0000)]
Merge "Update CREDITS"
Eddie Greiner-Petter [Sun, 7 May 2017 00:35:08 +0000 (02:35 +0200)]
Update CREDITS
Manual checks have shown that these people did really just start
contributing to core and didn't only switch mail adresses.
Change-Id: I8b09ae04a9d50a677d8491eb3fe6ff5af8dcaf53
jenkins-bot [Sun, 7 May 2017 05:57:48 +0000 (05:57 +0000)]
Merge "Upstream the transform mixin from MobileFrontend"
jdlrobson [Wed, 3 May 2017 00:31:48 +0000 (17:31 -0700)]
Upstream the transform mixin from MobileFrontend
This is useful and used by various extension including
CentralAuth, CodeEditor, Collection, Cards.
Change-Id: Iad3f568c4e7dbd7bd5a8c2058fe4b467750a9f07
jenkins-bot [Sun, 7 May 2017 00:53:00 +0000 (00:53 +0000)]
Merge "phpcs: Run MediaWiki.Commenting.FunctionComment.WrongStyle sniff"
Eddie Greiner-Petter [Sat, 6 May 2017 23:59:58 +0000 (01:59 +0200)]
Add DatabaseUpdater::modifyTable
This introduces the function modifyTable to the DatabaseUpdater class
which will allow to alter multiple columns on the same table in a single
sql patch file. In favor of this new function, usage of
MssqlUpdater::updateSchema for mssql patches is discouraged for the
future.
Also fix T70786, which is about update rows being inserted regardless
whether applying the patch was successful or not (no retry on failure).
Now update rows only get inserted if applying the patch was successful.
Bug: T70786
Change-Id: Id2a1583cd9efa5ef271ae67238119bc24b76a3c6
jenkins-bot [Sat, 6 May 2017 21:04:19 +0000 (21:04 +0000)]
Merge "Remove $wgDisableUserGroupExpiry feature flag"
Translation updater bot [Sat, 6 May 2017 20:03:31 +0000 (22:03 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I58d5e6eb92b935c8337e7ab730e59b23292b9201
Kunal Mehta [Sat, 6 May 2017 19:39:29 +0000 (12:39 -0700)]
phpcs: Run MediaWiki.Commenting.FunctionComment.WrongStyle sniff
All files in the repository currently pass.
Change-Id: I5549abfe8374ae4b6f8904c2d7870ea77b8ee17c
jenkins-bot [Sat, 6 May 2017 19:42:44 +0000 (19:42 +0000)]
Merge "Update mediawiki/mediawiki-codesniffer to 0.8.0"
Paladox [Thu, 4 May 2017 19:35:41 +0000 (19:35 +0000)]
Update mediawiki/mediawiki-codesniffer to 0.8.0
Change-Id: I11c4e0e519589c2d005896bf9d3758ef017346fb
Amire80 [Sat, 6 May 2017 17:56:44 +0000 (20:56 +0300)]
Add single angle quotation marks and to special characters
These marks are used quite frequently in articles about
linguistics, characters, alphabets, etc., to mark graphemes.
Change-Id: I63e890d68d4bf43f3d1886ce45891d0f3edafd14
TTO [Fri, 5 May 2017 01:37:55 +0000 (01:37 +0000)]
Fix a couple of issues with cleanupInvalidDbKeys.php maint script
- The output was pretty screwed. Now it works properly if you redirect
STDOUT to a file like you're supposed to.
- \r, \n, and \t characters were escaped wrongly (for example, \r was
escaped to \\r, which matches a literal sequence of '\' and 'r'). Now
they are correctly escaped to \r, \n and \t in the SQL query.
Change-Id: I750b4fb3e7072ae3cdd8c40733b066a1e76de366
This, that and the other [Tue, 11 Apr 2017 02:32:02 +0000 (12:32 +1000)]
Remove $wgDisableUserGroupExpiry feature flag
This feature flag was added to comply with WMF's schema change policy.
It is no longer needed now that the feature is enabled on WMF sites.
External MW installations will run update.php or manually do DB updates
as required before upgrading MW.
Bug: T162517
Change-Id: I5b532d79fd1e8b178490cf2617499ae62967de2c
Timo Tijhof [Sat, 6 May 2017 00:26:01 +0000 (17:26 -0700)]
config: Add @covers to complete GlobalVarConfig and MultiConfig
Change-Id: Ifff51c8b078ba3a3026720f13263c7af0d7d1145
jenkins-bot [Sat, 6 May 2017 00:14:33 +0000 (00:14 +0000)]
Merge "jquery.ui: Avoid deprecated jQuery.expr[":"]"
Fomafix [Sat, 29 Apr 2017 19:00:04 +0000 (21:00 +0200)]
Clear postEdit cookie on server-side
* Load module 'mediawiki.action.view.postEdit' only when needed.
* Transfer message key via JavaScript config variable wgPostEdit.
* The response is maked as not-cachable to prevent that other users get the
post edit message.
This change redefines the global JavaScript variable wgPostEdit from true
to a string and set it on server-side.
Bug: T164148
Change-Id: Id780bc280ce4a2fa4606141419932b7dcd45157b
Roan Kattouw [Fri, 5 May 2017 23:55:30 +0000 (16:55 -0700)]
SpecialRecentchanges: Add class="mw-recentchanges-toplinks" to the "top links"
Meaning the contents of [[MediaWiki:Recentchangestext]], which is a series
of quick links on most wikis.
Bug: T164617
Change-Id: I2934156af5aafa3162924ecf78cfd82d3a41370d
Timo Tijhof [Fri, 5 May 2017 23:31:25 +0000 (16:31 -0700)]
jquery.ui: Avoid deprecated jQuery.expr[":"]
Compatible with jQuery 1.11 and 3.x, as jQuery.expr.pseudos was
introduced in jQuery 1.8.
Note that this is not blocking jQuery 3 (T124742) since it is
covered by jQuery Migrate. But fixing this makes the edit page less
noisy by default.
Change-Id: I7ffbfd2e55aa7dcc31860eb0117b203e63ca7283
jenkins-bot [Fri, 5 May 2017 20:52:19 +0000 (20:52 +0000)]
Merge "Properly detect if CACHE_ACCEL is available in the installer"
Timo Tijhof [Fri, 5 May 2017 20:20:43 +0000 (13:20 -0700)]
phpunit: Fix broken @covers for swapICCProfile in JpegTest
Follows-up
a428e3f067.
Change-Id: I5755dc560fbb3314578775839b02653a4e2113d5
Translation updater bot [Fri, 5 May 2017 19:56:46 +0000 (21:56 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I498e214dec5f3939847016861b27ebd2a45e7fe1
jenkins-bot [Fri, 5 May 2017 18:58:22 +0000 (18:58 +0000)]
Merge "CSSMin: Support parenthesis and quotes in url references"
jenkins-bot [Fri, 5 May 2017 18:57:38 +0000 (18:57 +0000)]
Merge "resourceloader: Add CSSMin benchmarks"
Timo Tijhof [Thu, 4 May 2017 02:54:52 +0000 (19:54 -0700)]
CSSMin: Support parenthesis and quotes in url references
Previously they were often being cut short due to the url pattern
ending at the first single quote, double quote or closing parenthesis
regardless of which of those started the url match.
Running benchmarkCSSMin.php before and after the change doesn't seem
produce consistent improvement or regression. Repeated runs with count=100
with and without this change both have a median between 2.6ms and 2.9ms
using PHP 5.6, and between 2.6ms and 2.8ms using HHVM 3.12.
Bug: T60473
Change-Id: I6d6a077ad76588f3ed81b1901a26b7e56d2157ee
jenkins-bot [Fri, 5 May 2017 15:16:59 +0000 (15:16 +0000)]
Merge "RCFilter UI: allow getParametersFromFilters to accept filter list"
jenkins-bot [Fri, 5 May 2017 13:30:58 +0000 (13:30 +0000)]
Merge "ApiQueryTags: Use cached statistics instead of querying hit counts ourselves"
jenkins-bot [Fri, 5 May 2017 12:32:37 +0000 (12:32 +0000)]
Merge "Fix php code style"
Paladox [Thu, 4 May 2017 19:35:41 +0000 (19:35 +0000)]
Fix php code style
Preparation change for updating mediawiki code sniffer to 0.8.0
Change-Id: Ib0b3fe4afea9096ffa3a1347b4f7e07d3398b0b2
Kaldari [Fri, 5 May 2017 03:08:00 +0000 (20:08 -0700)]
Writing a useful description for the FakeConverter class
Change-Id: I6575ea13790c224c1b25c7e9373b4bf40d035a30
jenkins-bot [Fri, 5 May 2017 02:02:44 +0000 (02:02 +0000)]
Merge "Fix registerTempTableOperation() return value for non-temporary table DROPs"
Roan Kattouw [Fri, 5 May 2017 01:04:58 +0000 (18:04 -0700)]
ApiQueryTags: Use cached statistics instead of querying hit counts ourselves
The hit count query was quite slow. Unfortunately, it seems that we do need
tagUsageStatistics() even when hitcounts are not requested, because it
might list additional tags that aren't listed by the list*Tags() functions.
I don't know if this can happen in practice, but all the code around tags
seems to operate as if it might.
Bug: T164552
Change-Id: Ifccf7f5ac7a1220ff67a68589398cbf30aefd3ad
jenkins-bot [Fri, 5 May 2017 00:31:02 +0000 (00:31 +0000)]
Merge "EtcdConfig: Fix infinite timeout bug, and reduce timeout"
jenkins-bot [Thu, 4 May 2017 22:55:38 +0000 (22:55 +0000)]
Merge "build: Update eslint to 0.4.0 and make pass"
Ed Sanders [Thu, 4 May 2017 15:59:40 +0000 (16:59 +0100)]
build: Update eslint to 0.4.0 and make pass
Change-Id: Ib230392f332268ac801cf668f399fcefb1cb1cc5
Aaron Schulz [Thu, 4 May 2017 20:09:27 +0000 (13:09 -0700)]
Fix registerTempTableOperation() return value for non-temporary table DROPs
Change-Id: I338dfbbf5479d5157de8d9abc2012cc0e7d10c93
Translation updater bot [Thu, 4 May 2017 20:11:51 +0000 (22:11 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I6e3920bd06e5ca5462d392a569c817e46e041fcc
jenkins-bot [Thu, 4 May 2017 18:16:36 +0000 (18:16 +0000)]
Merge "Fix contradictory RC filters and add back-compat"
jenkins-bot [Thu, 4 May 2017 16:51:47 +0000 (16:51 +0000)]
Merge "mw.special.apisandbox: Don't pass $label to OO.ui.FieldLayout"
jenkins-bot [Thu, 4 May 2017 16:39:15 +0000 (16:39 +0000)]
Merge "Fix typo in DBConnReff class phpdoc"
jenkins-bot [Thu, 4 May 2017 16:38:08 +0000 (16:38 +0000)]
Merge "Fix inconsistent spec of InterwikiLookup::getAllPrefixes."
jenkins-bot [Thu, 4 May 2017 15:54:49 +0000 (15:54 +0000)]
Merge "Remove unused var assign in Parser::getTemplateDom"
jenkins-bot [Thu, 4 May 2017 13:03:54 +0000 (13:03 +0000)]
Merge "Follow-up
bac92e67ca0: make order of filter groups less misleading"
Stephane Bisson [Tue, 6 Dec 2016 15:25:35 +0000 (10:25 -0500)]
Fix contradictory RC filters and add back-compat
Some combinations of RC filters should never appear
together because they guarantee to return no data
and cannot be visually represented in the new RC
filters UI (ERI project).
Examples include:
* 'hidemyself' and 'hidebyothers'
* 'hideminor' and 'hidemajor'
* All of the filters in the changeType group (which
is extended by extensions)
This also handles an old special case, but it now redirects
instead of doing it silently:
hideanons=1 & hideliu=1 & hidebots=1 -> hideliu=1 & hidebots=1
hideanons=1 & hideliu=1 & hidebots=0 -> hidehumans=1
Bug: T151873
Change-Id: Id08dccd07b262ce61c9d38563f19a0ab181e2341
jenkins-bot [Thu, 4 May 2017 08:46:35 +0000 (08:46 +0000)]
Merge "Fix all the Doxygen for the RCFilters backend"
daniel [Tue, 2 May 2017 19:44:05 +0000 (21:44 +0200)]
Fix inconsistent spec of InterwikiLookup::getAllPrefixes.
The documented return type was not what existing callers expected,
and not what the default implementation actually returned.
This patch fixes the interface documentation and the behavior of
an alternative implementation.
Change-Id: Ib09bffeba3ddc5b43da1c7c299f1fa946be4e2e2
addshore [Thu, 4 May 2017 08:20:43 +0000 (10:20 +0200)]
Fix typo in DBConnReff class phpdoc
Change-Id: Iba61678fb0b6bd63a1c15a074adc9d9523384cb7
jenkins-bot [Thu, 4 May 2017 07:59:08 +0000 (07:59 +0000)]
Merge "Embed TinyRGB color profile when JPG EXIF Color Space = sRGB but no profile embedded"
Brad Jorsch [Tue, 28 Jul 2015 16:17:40 +0000 (12:17 -0400)]
Change default $wgShellLocale to C.UTF-8, and use it to set LC_ALL
It's less likely to cause surprises than language-specific defaults.
Bug: T107128
Change-Id: Ife7673255798f3a3d72028a26607c56b9b7fb224
Tim Starling [Thu, 4 May 2017 05:07:11 +0000 (15:07 +1000)]
EtcdConfig: Fix infinite timeout bug, and reduce timeout
removeServer() returns the modified array, rather than passing by
reference, so you have to use the return value to avoid an infinite loop
when a server is down.
Tune the timeout downwards, to 2s. With three servers in the SRV pool,
if they are all unreachable, this will mean an overall request time of
6s, which is conveniently less than the APC lock time and the cache
TTL (9-10s). If the APC lock time is significantly shorter than the time
it takes to do the HTTP requests, then additional threads join in
waiting for the server. This could have stability consequences if the
maximum HHVM worker count is exceeded.
Change-Id: I3176aa41b8833c0ba0b668859e59911cd4392250
Timo Tijhof [Thu, 4 May 2017 04:00:14 +0000 (21:00 -0700)]
resourceloader: Add CSSMin benchmarks
Usage:
# Run default benchmark
$ php maintenance/benchmarks/benchmarkCSSMin.php
# Use custom file
$ php maintenance/benchmarks/benchmarkCSSMin.php --file resources/lib/qunitjs/qunit.css
# Debug the output for inspection (no benchmark)
$ php maintenance/benchmarks/benchmarkCSSMin.php --out
Change-Id: I70d118131d0ff16d1a811b2de1328ea622b7ca69
Timo Tijhof [Thu, 4 May 2017 03:17:54 +0000 (20:17 -0700)]
benchmarks: Convert benchmarkHooks to use Benchmarker
Also change benchmarkPurge to *not* use Benchmarker since it
doesn't use bench() or any other Benchmarker method.
Change-Id: I5d8ace161ecf1e05d69abf2f242e3684ffe48fa0
Matthew Flaschen [Thu, 4 May 2017 00:04:29 +0000 (20:04 -0400)]
Revert "Convert mwdoc-filter.php to Maintenance", rm wfShellWikiCmd
Revert
a58948d64 and instead remove wfShellWikiCmd and escape
shell arguments directly.
This should be fine since mwdoc-filter.php does not depend on per-wiki
state.
Change-Id: Id9c6ca84bab827675b71ca16bf688fd3f5c993a1